Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep auth header untouched #178

Merged
merged 4 commits into from
Dec 15, 2022
Merged

Conversation

dirkkul
Copy link
Collaborator

@dirkkul dirkkul commented Dec 13, 2022

closes #177

@codecov-commenter
Copy link

codecov-commenter commented Dec 13, 2022

Codecov Report

Base: 96.41% // Head: 96.41% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (7e6b492) compared to base (527759c).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #178   +/-   ##
=======================================
  Coverage   96.41%   96.41%           
=======================================
  Files          57       57           
  Lines        6717     6724    +7     
=======================================
+ Hits         6476     6483    +7     
  Misses        241      241           
Flag Coverage Δ
unittests 96.41% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
weaviate/connect/connection.py 93.71% <100.00%> (+0.12%) ⬆️
weaviate/warnings.py 96.77% <100.00%> (+0.47%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dirkkul dirkkul requested a review from StefanBogdan December 14, 2022 17:07
weaviate/connect/connection.py Outdated Show resolved Hide resolved
weaviate/connect/connection.py Show resolved Hide resolved
@dirkkul dirkkul merged commit 64572c1 into main Dec 15, 2022
@dirkkul dirkkul deleted the enable_header_auth_to_non_weaviate branch December 22, 2022 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with auth bearer token validation (unreleased)
3 participants